[deps] update flask to latest version #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminPelletier
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Huh, well that's cool. I wouldn't have expected this to work, but I think the CI should be reliable, so apparently we were just micromanaging packages. I'm going to ask @barroco to take a look also to see if he's thinking of something I'm not, but this looks great to me.
|
Agree on the fact that the CI should be reliable. I expect this is a benefit of having removed the webapp from the repository. (see #246) |
github-actions bot
added a commit
that referenced
this pull request
Dec 19, 2023
[deps] update flask e61034b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #329 and was obtained through a few iterative updates (it was not immediately obvious to me that the transitive dependencies with a pinned version could simply be removed)
Note that this removes the explicit version pinning of
Werkzeug,Jinja2anditsdangerous.If we need to pin transitive dependencies (which is a generally good idea) I'd suggest looking into something such as pip-tools (or rolling our own crude version pinning with eg
pip freeze).However, there is no urgency with this, as long as dependency management does not start taking too much time.