[uss_qualifier] op-intent refs ACL checks: skip scenario if references can't be cleaned up (fix #418) #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
418-acl-ws-cleanup
branch
3 times, most recently
from
616135d to
024b9be
Compare
Shastick
changed the title
…an't be cleaned up (fix interuss#418)
Shastick
force-pushed
the
418-acl-ws-cleanup
branch
from
024b9be to
335ecf2
Compare
BenjaminPelletier
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit check to
OpIntentReferenceAccessControlto verify that the workspace is clean, and skip the scenario steps if it is not.This also moves the
PrepareFlightPlannersin front ofForEachDSSin thef3548_21.yamltest suite configuration, as the stray OIRs reported in #418 seem not to belong to the op intent reference ACL test scenario and there is a higher chance of them getting cleaned up this way.(This scenario will attempt to cleanup up stray OIRs that seem to belong to the credentials that are being used, but it can't possibly clean up references that are owned by other credentials)
In the event of cleanup failure, the scenario has been updated to simply skip all further checks.