[uss_qualifier] Relax type requirements when performing test checks #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common problem in uss_qualifier is developers providing a single ParticipantID rather than a list of ParticipantIDs when initiating a check. Since a ParticipantID is a string and a string is actually a list (of characters), this problem often goes unnoticed and participants are attributed as "u", "s", "s", and "1". This is currently a problem both in an active PR and a PR that was merged (was not caught in review).
This PR fixes that problem by allowing either a single ParticipantID or a list of ParticipantIDs to be provided, and treats either correctly. It also does the same for requirements where the same problem sometimes occurs.