[uss_qualifier] Fix non-cached sub information #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Dec 4, 2023
github-actions bot
added a commit
that referenced
this pull request
Dec 4, 2023
Fix non-cached sub information eab87f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent IDGenerator change to more properly separate out obtaining of subscriber information into another resource introduced a bug because
issue_tokendoes not cache tokens whereasget_subdepends on cached tokens. This PR fixes that issue by triggering a token cache update withget_headersrather thanissue_token. It also removes the specialget_subimplementation for DummyOAuth because, while it is more efficient, it exercises less of the standard code paths.This issue was raised by a user and the content in this PR was informally verified to fix the issue.