-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] Adding the interactions and invalid op checks steps #376
Merged
BenjaminPelletier
merged 42 commits into
interuss:main
from
punamverma:interactions_and_invalid_op_checks
Dec 17, 2023
+797
−183
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
e2e55c8
Adding the interactions and invalid op checks steps
punamverma 84c59cc
Added mock_uss to prep_planners doc
punamverma 83e1e08
fix format
punamverma 2ddb964
Fix doc
punamverma 1a6622f
Adding missing code
punamverma ce4488e
Adding missing mock_uss resource to PrepareFlightPlanners
punamverma 2aa5f05
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma a44b49e
Fix per PR comments
punamverma 907cbfe
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma c2e8bf6
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 9687ac2
Removing post check for a particular url
punamverma 83a40d8
Fixing check details
punamverma 3a8bdc4
Adding 5 s back, removing url check no post interactions
punamverma 3df884c
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 42cceda
Wait only for checking POST notifications
punamverma 8fdcb69
Fix per PR comments
punamverma 8797056
Fix per PR review
punamverma 9abdf23
Fix format
punamverma fbae1b1
Refactoring code, removed wait time for other than post interactions …
punamverma 40bc79c
querying for interactions optimistically
punamverma 22931da
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma d282151
Fix passing ref id
punamverma f892e01
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 2c7dba1
Update monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_vali…
punamverma b330dff
Fix per review comments
punamverma 1fcbafa
Fix per review
punamverma fca841f
Adding missing code for Query
punamverma 688dd4c
Fixed documentation for wait time as per PR comments
punamverma e9b0566
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 1405f0e
Adding subscription check with GET request check
punamverma 694ff22
Fixed per PR comments
punamverma 4bcb865
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 1f588ec
Fix per review
punamverma 75d57b1
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 62f1155
Removing args from comments
punamverma 844fb4b
Conditional call of GET request based on notification
punamverma 7999f53
Refining check message
punamverma aa89491
Removing else condition, and renaming test step and check as discussed
punamverma ee8d6cb
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma 2e4d228
Changing method name per review
punamverma d09dab5
fixing the condition for GET request check
punamverma 2ce1399
Want to trigger CI run that failed on netrid test
punamverma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Changing method name per review
commit 2e4d2286e74efa77cc7cf27bdeb171ddb70f3e1c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A useful tool to check the correctness/behavior of uss_qualifier functionality is to inspect the various artifacts produced from a test run. The CI runs most of the configurations in configurations/dev with output going to uss_qualifier/output -- this output is available as a downloadable artifact when the CI is run on GitHub, or it will be on your local machine if run locally. Here is a portion of the tested requirements artifact for the f3548_self_contained test configuration:
It seems like we would want to make sure that check happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed the condition.
But, I see that there are some subscriptions that are not getting cleaned up, and causing notifications to happen.