Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] Adding the interactions and invalid op checks steps #376

Merged
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
e2e55c8
Adding the interactions and invalid op checks steps
punamverma Nov 29, 2023
84c59cc
Added mock_uss to prep_planners doc
punamverma Nov 29, 2023
83e1e08
fix format
punamverma Nov 29, 2023
2ddb964
Fix doc
punamverma Nov 29, 2023
1a6622f
Adding missing code
punamverma Nov 29, 2023
ce4488e
Adding missing mock_uss resource to PrepareFlightPlanners
punamverma Nov 30, 2023
2aa5f05
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Nov 30, 2023
a44b49e
Fix per PR comments
punamverma Dec 1, 2023
907cbfe
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 1, 2023
c2e8bf6
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 1, 2023
9687ac2
Removing post check for a particular url
punamverma Dec 1, 2023
83a40d8
Fixing check details
punamverma Dec 1, 2023
3a8bdc4
Adding 5 s back, removing url check no post interactions
punamverma Dec 1, 2023
3df884c
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 2, 2023
42cceda
Wait only for checking POST notifications
punamverma Dec 2, 2023
8fdcb69
Fix per PR comments
punamverma Dec 4, 2023
8797056
Fix per PR review
punamverma Dec 4, 2023
9abdf23
Fix format
punamverma Dec 4, 2023
fbae1b1
Refactoring code, removed wait time for other than post interactions …
punamverma Dec 6, 2023
40bc79c
querying for interactions optimistically
punamverma Dec 7, 2023
22931da
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 7, 2023
d282151
Fix passing ref id
punamverma Dec 7, 2023
f892e01
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 7, 2023
2c7dba1
Update monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_vali…
punamverma Dec 8, 2023
b330dff
Fix per review comments
punamverma Dec 8, 2023
1fcbafa
Fix per review
punamverma Dec 8, 2023
fca841f
Adding missing code for Query
punamverma Dec 8, 2023
688dd4c
Fixed documentation for wait time as per PR comments
punamverma Dec 11, 2023
e9b0566
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 11, 2023
1405f0e
Adding subscription check with GET request check
punamverma Dec 12, 2023
694ff22
Fixed per PR comments
punamverma Dec 13, 2023
4bcb865
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 13, 2023
1f588ec
Fix per review
punamverma Dec 14, 2023
75d57b1
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 14, 2023
62f1155
Removing args from comments
punamverma Dec 14, 2023
844fb4b
Conditional call of GET request based on notification
punamverma Dec 14, 2023
7999f53
Refining check message
punamverma Dec 14, 2023
aa89491
Removing else condition, and renaming test step and check as discussed
punamverma Dec 15, 2023
ee8d6cb
Merge branch 'main' into interactions_and_invalid_op_checks
punamverma Dec 15, 2023
2e4d228
Changing method name per review
punamverma Dec 16, 2023
d09dab5
fixing the condition for GET request check
punamverma Dec 16, 2023
2ce1399
Want to trigger CI run that failed on netrid test
punamverma Dec 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changing method name per review
punamverma committed Dec 16, 2023
commit 2e4d2286e74efa77cc7cf27bdeb171ddb70f3e1c
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@
)
from monitoring.uss_qualifier.scenarios.astm.utm.data_exchange_validation.test_steps.expected_interactions_test_steps import (
expect_interuss_post_interactions,
expect_get_requests_to_mock_uss,
expect_get_requests_to_mock_uss_when_no_notification,
expect_no_interuss_post_interactions,
check_any_notification,
)
@@ -197,7 +197,7 @@ def _tested_uss_plans_deconflicted_flight_near_existing_flight(
)

if tested_uss_notified:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A useful tool to check the correctness/behavior of uss_qualifier functionality is to inspect the various artifacts produced from a test run. The CI runs most of the configurations in configurations/dev with output going to uss_qualifier/output -- this output is available as a downloadable artifact when the CI is run on GitHub, or it will be on your local machine if run locally. Here is a portion of the tested requirements artifact for the f3548_self_contained test configuration:

Screenshot 2023-12-15 at 3 55 05 PM

It seems like we would want to make sure that check happened.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed the condition.
But, I see that there are some subscriptions that are not getting cleaned up, and causing notifications to happen.

expect_get_requests_to_mock_uss(
expect_get_requests_to_mock_uss_when_no_notification(
self,
self.control_uss,
planning_time,
@@ -292,7 +292,7 @@ def _tested_uss_unable_to_plan_flight_near_invalid_shared_existing_flight(
validator.expect_not_shared()

if tested_uss_notified:
expect_get_requests_to_mock_uss(
expect_get_requests_to_mock_uss_when_no_notification(
self,
self.control_uss,
planning_time,
Original file line number Diff line number Diff line change
@@ -100,7 +100,7 @@ def expect_no_interuss_post_interactions(
scenario.end_test_step()


def expect_get_requests_to_mock_uss(
def expect_get_requests_to_mock_uss_when_no_notification(
scenario: TestScenarioType,
mock_uss: MockUSSClient,
st: StringBasedDateTime,