[uss_qualifier] nominal_behavior – align requirements on observations with the standard #374
Conversation
Shastick
force-pushed
the
369-optional-observation-data
branch
from
a326f8b to
853f23e
Compare
…(optional altitude and state)
Shastick
force-pushed
the
369-optional-observation-data
branch
from
853f23e to
6dd2909
Compare
| logger.debug(f"Observed flight: {observed_flight.current_state}") | ||
| # If the state is present, we do validate its content, | ||
| # but its presence is optional | ||
| if injected_flight.has_field_with_value("current_state"): |
There was a problem hiding this comment.
@BenjaminPelletier with this change (and the fact that the check was removed from the doc) we assume that there is no need to record specifically that the field is present (I was wondering if this would be required as part of a capability, but I've never set one up myself so am quite unsure)
There was a problem hiding this comment.
Capabilities are built on requirements, so if there's no requirement for a field to be present, being present shouldn't be part of the capability. But, when the field is present, there is a requirement that it satisfies some conditions, and verification of that requirement (which will only happen when the field is present) is what the capability would be based on.
| logger.debug(f"Observed flight: {observed_flight.current_state}") | ||
| # If the state is present, we do validate its content, | ||
| # but its presence is optional | ||
| if injected_flight.has_field_with_value("current_state"): |
There was a problem hiding this comment.
Capabilities are built on requirements, so if there's no requirement for a field to be present, being present shouldn't be part of the capability. But, when the field is present, there is a requirement that it satisfies some conditions, and verification of that requirement (which will only happen when the field is present) is what the capability would be based on.
This should fix #369: The
current_stateandaltitudefield presence is not enforced anymore(But we still check their content if they are returned)
Note this also cleans up some old troubleshooting log entries.