Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier/scd] Add 'Down USS' scenario; SCD0005 requirement validation #366

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

mickmis
Copy link
Contributor

@mickmis mickmis commented Nov 24, 2023

This also adds some things we need:

  • additional functions to query the DSS
  • utility function to extract generically an error message from a query response
  • generic test steps to change availability of an USS

Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I do think we want to make sure the code works as part of the PR, but this can be easily accomplished (I did so locally) by adding something like this section before the aggregate checks in the f3548_21 test suite:

- action_generator:
    generator_type: action_generators.flight_planning.FlightPlannerCombinations
    resources:
      flight_planners: flight_planners
      conflicting_flights: conflicting_flights
      dss: dss
    specification:
      flight_planners_source: flight_planners
      roles:
        - tested_uss
      action_to_repeat:
        test_scenario:
          scenario_type: scenarios.astm.utm.off_nominal_planning.down_uss.DownUSS
          resources:
            tested_uss: tested_uss
            dss: dss
            flight_intents: conflicting_flights
        on_failure: Continue
  on_failure: Continue

@mickmis
Copy link
Contributor Author

mickmis commented Nov 30, 2023

Thanks, this looks great! I do think we want to make sure the code works as part of the PR, but this can be easily accomplished (I did so locally) by adding something like this section before the aggregate checks in the f3548_21 test suite:

Of course! Forgot to include it. I had it locally and the test ran fine. Updating now.

@BenjaminPelletier BenjaminPelletier merged commit ddca813 into interuss:main Nov 30, 2023
9 checks passed
github-actions bot added a commit that referenced this pull request Nov 30, 2023
…dation (#366)

* [uss_qualifier/scd] Add 'Down USS' scenario

* add down USS action to f3548 suite

* fix None str return

* use error_message ddca813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants