Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uss_qualifier] Wire additional resources into certain configurations to avoid warnings #363

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[uss_qualifier] Wire additional resources into certain configurations to avoid warnings #363

merged 1 commit into from
Nov 28, 2023

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Nov 22, 2023 •
edited
Loading

Ran into some warnings about missing resources when troubleshooting the builds for #362: I do not know if this is actually a problem or if it needs fixing.

Warnings I got when running eg ./run_locally.sh configurations.dev.message_signing locally on master (or when running all the configurations) – it's only one of them, as I had to iteratively fix them until it worked,

2023-11-22 14:02:00.993 | WARNING  | monitoring.uss_qualifier.suites.suite:__init__:259 - Skipping action 1 (test_suite suites.astm.utm.f3548_21) because Test suite "ASTM F3548-21" is missing resource invalid_flight_intents (resources.flight_planning.FlightIntentsResource)

@Shastick Shastick changed the title Troubleshooting [uss_qualifiier] tentatively wire additional resources into certain configurations to avoid warnings when running locally Nov 22, 2023
@Shastick Shastick marked this pull request as ready for review November 22, 2023 14:45
@barroco barroco changed the title [uss_qualifiier] tentatively wire additional resources into certain configurations to avoid warnings when running locally [uss_qualifier] tentatively wire additional resources into certain configurations to avoid warnings when running locally Nov 22, 2023
BenjaminPelletier
BenjaminPelletier approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was semi-intentional to keep down the CI time by not repeating test suites in multiple configurations. But, it's probably worth spending a bit of additional time to provide a bit more coverage.

@BenjaminPelletier BenjaminPelletier changed the title [uss_qualifier] tentatively wire additional resources into certain configurations to avoid warnings when running locally [uss_qualifier] Wire additional resources into certain configurations to avoid warnings Nov 28, 2023
@BenjaminPelletier BenjaminPelletier merged commit 16e6740 into interuss:main Nov 28, 2023
9 checks passed
github-actions bot added a commit that referenced this pull request Nov 28, 2023
@github-actions
[uss_qualifier] Wire additional resources into certain configurations…
bbd9229 
… to avoid warnings (#363)

[uss_qualifier] fix warning about a skippd scenario due to missing resource in f3548_self_contained.yaml 16e6740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminPelletier BenjaminPelletier BenjaminPelletier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shastick @BenjaminPelletier