[uss_qualifier] Fix schema generation logic #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Nov 21, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 23, 2023
Fix schema generation logic b32d925
github-actions bot
added a commit
to Orbitalize/monitoring
that referenced
this pull request
Nov 24, 2023
Fix schema generation logic b32d925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with our JSON Schema generation logic currently: 1)
make check-hygienedoesn't check schemas, and therefore generated schema verification is actually not part of our CI currently, and 2)make formatuses the default docker user to create schema files and this normally means the resulting files are owned by root rather than the invoking user. This PR resolves both of those issues.