[uss_qualifier] MockUssClient and test steps with FlightPlannerClient #347
Conversation
punamverma
commented
Nov 16, 2023
punamverma
commented
- Added V1FlightPlannerClient to MockUssClient, as we ll use MockUssClient for planning flights in test scenarios.
- Added tests steps that use V1FlightPlannerClient for planning flights.
…n flight using FlightPlannerClient
punamverma
changed the title
|
@BenjaminPelletier PR is ready for review. Thanks |
There was a problem hiding this comment.
In addition to the comments below, we want to make sure the code works. Since these steps are being developed for a scenario that is already documented and already has an empty implementation, it should only take a few lines to call the new steps (plan_flight and cleanup_flights_fp_client) from that scenario so that nearly all of the code in the PR is actually exercised by the CI. We don't need to implement all steps of that scenario in this PR, but calling each of these two new steps once would provide nearly full test coverage of the changes in this PR.
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Pelletier <[email protected]>
|
@BenjaminPelletier Fixed the review comments. Added some steps in scenario to use the new test_steps methods. Could you please check. Thanks. |
|
@BenjaminPelletier @barroco @mickmis PR is ready for your review. Thanks |
monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_validation/get_op_data_validation.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
|
@BenjaminPelletier @barroco @mickmis Fixed PR comments. Ready for another review. |
…#347) * Added V1FlightPlannerClient to MockUssClient; added test steps to plan flight using FlightPlannerClient * Removing unwanted port mapping * Removing unwanted import * Update monitoring/uss_qualifier/resources/interuss/mock_uss/client.py Co-authored-by: Benjamin Pelletier <[email protected]> * Fixing per PR review comments * Remove an unwanted import * Adding missing code * Removing code causing failure * Fix bug * Fix format * Fix bug * Update monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py Co-authored-by: Benjamin Pelletier <[email protected]> * Fixing PR review comments * Removing if condition not required * Fix per PR review * Nit fix per review --------- Co-authored-by: Benjamin Pelletier <[email protected]> 58fdbcb
