[uss_qualifier] Improve dynamic time specification #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
approved these changes
Nov 21, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 21, 2023
* Improve dynamic time specification * Update hash * Update concurrently-edited get_op_data_validation scenario b151a97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, uss_qualifier produces dynamic times (for telemetry, flight intents, etc) relevant to the current test run from static definitions in just one way: specifying times relative to "start of test". However, it is unclear when the "test" starts (test run? test scenario? test step?) and this does not provide enough flexibility for many use cases. For instance, a test designer may want to activate flights "now" and not at a particular time relative to the start of the "test".
This PR replaces start_of_test with a more flexible TimeDuringTest construct that allows the specification of many potentially-relevant dynamic times, initially including start of test run, start of test scenario, and "time of evaluation" (as close to "now" as is feasible).