[uss_qualifier] DSS0030 token validation scenario #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
commented
Nov 13, 2023
Comment on lines
+577
to
+581
| # TODO confirm that we can consider the display provider scope as a 'read only scope' | ||
| if scope_intent == "read": | ||
| return v22a.constants.Scope.DisplayProvider | ||
| else: | ||
| return v22a.constants.Scope.ServiceProvider |
There was a problem hiding this comment.
As far as the tests are concerned, the DisplayProvider scope indeed prevents any mutation or deletion. In my understanding of the standard, a Display Provider is indeed not supposed to register an ISA, but I'd just want this to be confirmed by a second opinion.
There was a problem hiding this comment.
Confirmed -- a DisplayProvider is allowed to create and manage Subscriptions, but is not providing identification service, and therefore may not create nor manage Identification Service Areas.
BenjaminPelletier
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an almost direct port of the old
test_token_validation.pyv1 scenario, but it supports both versions of the standard.There is the possibility for also testing the endpoints for searching ISAs, which I can do in a later PR.