[uss_qualifier] dss_wrapper's handle_query_result function is made public #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
make-handle-q-result-public
branch
from
c92e547 to
14394eb
Compare
There was a problem hiding this comment.
Making the function public seems fine to me, though I think we will probably want to document it in that case
Shastick
force-pushed
the
make-handle-q-result-public
branch
from
14394eb to
600112a
Compare
Shastick
force-pushed
the
make-handle-q-result-public
branch
from
600112a to
99dbade
Compare
BenjaminPelletier
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to reflect its use in
isa_validation.py: most if not all scenarios that have aDSSWrapperhave access to its internals one way or another, so keepinghandle_query_resultprivate does not protect much.If there is an important reason I missed, I'm happy to do the necessary adaptations in
isa_validation.py