[uss_qualifier] DSS0030 let subscription_simple create subscriptions that don't set optional parameters #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
sub-simple-enable-opt-args
branch
from
afa9215 to
2ef11a3
Compare
BenjaminPelletier
approved these changes
Nov 9, 2023
| query_timestamps=query_timestamps, | ||
| ) | ||
| # When expect_end_time has not been defined, there is no clear specification on | ||
| # what the returned start time should be, so we only check it when we have requested one |
…hat don't set optional parameters
Shastick
force-pushed
the
sub-simple-enable-opt-args
branch
from
2ef11a3 to
b172321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification (the standard or the OpenAPI spec) don't say much on what should happen when optional parameters are not set, so I have not added any particular checks for these situations.
Note that this also includes a little renaming for some cleanup checks in
isa_subscription_interactions: as is often the case when creating test subscriptions, it reveals some check naming issues in the cleanup checks of other scenarios.