[build] Exclude pyc files from image #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Nov 9, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 9, 2023
Exclude pyc files from image 1eacb0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, *.pyc files affect whether the monitoring image is rebuilt or not, so if someone using the repository has a tool that manipulates *.pyc files (e.g., a full-featured IDE like IntelliJ), they will build the monitoring image far more frequently than is necessary. This PR excludes prebuilt *.pyc files from the image and removes them as a make dependency. Removing prebuilt *.pyc files is also desirable generally as the host machine on which they are built may build them differently than the container in which the image is run.