-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifer] Add data validation scenario to ASTM F3548-21 suite #324
[uss_qualifer] Add data validation scenario to ASTM F3548-21 suite #324
Conversation
@BenjaminPelletier PR is ready for your review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Approval with comments means the PR should be good to merge after comments have been addressed (except nits don't need to be addressed; they can simply be acknowledged) -- just one non-nit comment here.
non_conflicting_flights: | ||
resource_type: resources.flight_planning.FlightIntentsResource | ||
specification: | ||
planning_time: '0:05:00' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This field doesn't exist in FlightIntentsSpecification any more and can be deleted (like the others in this file which weren't caught previously).
(note: "nit" means the reviewer is nit-picking and the comment doesn't have to be addressed in order to merge the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will remove planning_time in the next PR.
@@ -80,6 +90,14 @@ v1: | |||
# A USS that hosts a DSS instance is also a participant in the test, even if they don't fulfill any other roles | |||
participant_id: uss1 | |||
base_url: http://dss.uss1.localutm | |||
mock_uss: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In keeping with the rest of this file, there should be a comment explaining what this resource is -- we use this configuration as a "trainer" example when someone wants to create their own configuration, so it's important that its content be understandable for someone without other experience with configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment.
@BenjaminPelletier Acknowledged the comments. Added the missing comment. |
) * Added data validation scenario to suite * Fixing format * Adding missing comments f48a5df
Added data validation scenario to f3548_21 suite.