[uss_qualifier] Change USS_QUALIFIER_STOP_FAST to execution setting #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we short-circuit test run execution on the first failed check (by escalating it to Critical severity) according to an environment variable named USS_QUALIFIER_STOP_FAST. This PR moves control of this behavior into the configuration; specifically, under
execution.Since the ExecutionContext already has the execution configuration in order to control execution, this PR makes the context available to the base GenericTestScenario by requiring it as a parameter to begin_test_scenario. With the context (containing the stop_fast setting) available to the base GenericTestScenario, it simply constructs its PendingChecks with that setting.