Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] Use FlightIntentsResource in general flight authorization scenario #317

Merged

Conversation

BenjaminPelletier
Copy link
Member

Currently, the general flight authorization scenario defines FlightInfoTemplates (flight intent descriptions) directly in the FlightCheckTable. This is less than optimal because

  • We have other tooling for loading flight intents (specifically: FlightIntentsResource)
  • We may create more tooling to manage flight intents when in the standard form (a collection of FlightInfoTemplates)
  • Always fully defining flight intents in the table disallows definition of delta flight intents as FlightIntentsResource allows

This PR generalizes and expands the general flight authorization scenario's treatment of flight intents by only specifying a flight intent ID in the table, and then using a separate standard FlightIntentsResource to provide the actual flight intents. The dev configuration and associated resources are updated.

Also, one additional field is added to the FlightCheckTable to reflect the new generalized flight planning interface: ExecutionStyle.

When this PR is merged, users of the general flight authorization scenario will need to update their configurations to move their flight intent definitions out of the table and into a separate FlightIntentsResource.

@BenjaminPelletier BenjaminPelletier marked this pull request as ready for review November 4, 2023 06:19
@@ -0,0 +1,103 @@
intents:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to reference the $schema here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $schema elements are really just human-readable comments, but makes sense to have them in the intents; added.

@BenjaminPelletier BenjaminPelletier merged commit 0983ab4 into interuss:main Nov 7, 2023
8 checks passed
@BenjaminPelletier BenjaminPelletier deleted the general-flight-auth-intents branch November 7, 2023 17:04
github-actions bot added a commit that referenced this pull request Nov 7, 2023
…tion scenario (#317)

* Use FlightIntentsResource in general flight authorization scenario

* Add $schema per comments

* Update file hash 0983ab4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants