[uss_qualifier] Make start/end time optional parameters of make_volume_4d #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_4d and its callers
Shastick
force-pushed
the
rid-utils-optional-times-volume4d
branch
from
9ed05a2 to
4729305
Compare
BenjaminPelletier
approved these changes
Nov 2, 2023
| if start_time is not None | ||
| else {} | ||
| ), | ||
| **( |
There was a problem hiding this comment.
I didn't know you could put multiple kwargs as arguments -- nice :)
BenjaminPelletier
changed the title
github-actions bot
added a commit
to openskies-sh/monitoring
that referenced
this pull request
Nov 2, 2023
…e_4d (interuss#304) [uss_qualifier] make start/end time optional parameters of make_volume_4d and its callers eaa6227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adapts what is required for
DSSWrapperto create subscriptions with unspecified start and end times.