Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooling] Ignore venv directory in root make format target #289

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Oct 25, 2023

black was happily descending into my local venv directory when running make format at the root: such a setup seems common enough to warrant an exclusion by default.

This was tested on a fresh venv installed in the repository root.

@Shastick Shastick marked this pull request as ready for review October 25, 2023 08:14
@Shastick Shastick force-pushed the ignore-venv-in-format branch from 4a6fb42 to 939a5bb Compare October 25, 2023 08:19
@Shastick Shastick changed the title [misc] ignore venv directory in root Makefile format target [misc] ignore venv directory in root make format target Oct 25, 2023
@BenjaminPelletier BenjaminPelletier changed the title [misc] ignore venv directory in root make format target [tooling] Ignore venv directory in root make format target Oct 26, 2023
@BenjaminPelletier BenjaminPelletier merged commit d133866 into interuss:main Oct 26, 2023
8 checks passed
github-actions bot added a commit that referenced this pull request Oct 26, 2023
[misc] ignore venv directory in root Makefile format target d133866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants