[uss_qualifier] DSS0030 migrate isa expiry check from prober #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
dss0030-isa-expiry
branch
2 times, most recently
from
47b0a3a to
c062075
Compare
|
|
||
| Not allowing an ISA to be created violates **[astm.f3411.v22a.DSS0030,a](../../../../../requirements/astm/f3411/v22a.md)** | ||
|
|
||
| #### Expired ISAs are not part of search results check |
There was a problem hiding this comment.
Shouldn't the names or requirements of this check and the next be switched? It seems like a SearchISAs requirement would relate to a search results check and a GetISA requirement would relate to a queried-by-ID check
There was a problem hiding this comment.
Yes indeed, thanks.
Shastick
force-pushed
the
dss0030-isa-expiry
branch
from
c062075 to
30983a5
Compare
Shastick
force-pushed
the
dss0030-isa-expiry
branch
from
30983a5 to
3282f79
Compare
|
Fix check titles, a typo and rebase. |
BenjaminPelletier
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the existing
test_isa_expiry.pyprober test to a newISAExpirygeneric test scenario.