[tooling] Use make image to build image
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Oct 20, 2023
monitoring/build.sh
Outdated
| @@ -21,3 +21,4 @@ docker image build \ | |||
| --build-arg commit_hash="$(git rev-parse HEAD)" \ | |||
| . \ | |||
| || exit 1 | |||
| touch monitoring/image | |||
There was a problem hiding this comment.
nit: Would it make sense to use a text file and write inside its purpose? Something like:
"File created by monitoring/build.sh to keep track of the latest build run date time."
There was a problem hiding this comment.
We wouldn't want to name it differently, despite the value of making its purpose clear via, e.g., image.maketarget, since having the file named anything other than the makefile target makes management difficult within make. But content sounds good; updated.
github-actions bot
added a commit
that referenced
this pull request
Oct 20, 2023
* Use `make image` to build image * Make linter happy and clean up some scripts * Add explanatory content in placeholder file 98c3f0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compose a lot of make commands and shell scripts together, most of which need an up-to-date version of the monitoring image. Despite trying to signal build status through the DO_NOT_BUILD_MONITORING environment variable, we still repeatedly build the image on a single command invocation because that environment variable does not transmit through make files.
This PR resolves that issue by defining a well-formed make target for the image (correctly specifies its dependencies and generates a placeholder file with timestamp) and using that make target to build the image in all normal scripts (explicit build and release scripts still build the image regardless of currency).