Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] Clean up NetRID requirements #245

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

BenjaminPelletier
Copy link
Member

This PR attempts to clean up NetRID requirements in uss_qualifier.

First, some functional changes are made:

  • Scenario documentation validation is enhanced to detect requirements that aren't declared/documented
  • Scenario documentation validation and formatting is extended to linked test steps

Then, requirement definitions are adjusted:

  • Multi-part requirements are split (e.g., NET0260 + NET0270 in v19, NET0710, DSS0030)
  • Missing parts of multi-part requirements are added (e.g., NET0260,NetSpDataResponseTime95thPercentile, DSS0130,2,e)
  • Definitions of requirements that cannot be verified as a whole apart from their parts are removed (e.g., NET0260, NET0710, DSS0030)
  • Requirement names are improved (e.g., A2-6-1,* -> DSS0130,A2-6-1,*)

Then, requirement groups are updated to reflect the requirement definition changes, plus reviewed for accuracy. Importantly, NET0470 is removed as a requirement for DPs since DAs may choose not to request any particular field (per requirement clarification), so falsifiability cannot be guaranteed, essentially making this an "optional requirement".

Then, requirement references in test documentation are updated. In particular, we were incorrectly claiming DSS0030 in a number of places which has now been replaced by a new InterUSS requirement to achieve what we previously claimed ASTM requirements achieved. All of the newly-split requirements (including DSS0030) are updated in the appropriate places to specify which requirement part is being verified exactly.

The participant ID is supplied in a few checks where it wasn't previously so that the participant can take credit for the check.

A few tests are slightly adjusted to be more correct or take advantage of the requirements update.

A few requirement references are corrected.

A fair amount of autogenerated artifacts are regenerated.

Check and format included test scenario steps
@BenjaminPelletier BenjaminPelletier marked this pull request as ready for review October 12, 2023 05:42
@BenjaminPelletier BenjaminPelletier merged commit 1e42d08 into interuss:main Oct 13, 2023
9 checks passed
@BenjaminPelletier BenjaminPelletier deleted the netrid-req-cleanup branch October 13, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants