[uss_qualifier] NET0450 check that observed details (from a display provider) correspond to injected ones #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
net0450-details
branch
13 times, most recently
from
c207680 to
2a38645
Compare
Shastick
changed the title
Shastick
force-pushed
the
net0450-details
branch
from
2a38645 to
a298c4c
Compare
| operator_location, | ||
| Altitude.w84m(value=operator_altitude_value), | ||
| operator_altitude.get("altitude_type"), | ||
| injected_details.get("operator_location"), |
There was a problem hiding this comment.
Are we sure the "operator_location" key exists at this point? If not, this may raise a KeyError exception which will catastrophically stop the scenario. Same comment for other .get's without default values.
There was a problem hiding this comment.
Fair concern: there's no guarantee beyond "it currently works", I'll see that I add meaningful defaults.
…d to injected ones
Shastick
force-pushed
the
net0450-details
branch
from
a298c4c to
70e7d85
Compare
|
Added meaningful defaults to the |
BenjaminPelletier
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also validate details that are observed through the DP.
Note that this PR also replaces a few dashes (from – to -)