[uss_qualifier/reports] Add tested_requirements artifact #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminPelletier
force-pushed
the
feature/tested-requirements
branch
from
77be89f to
45025e6
Compare
mickmis
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
I assume that the deletion of the following two files are just some cleanup and do not break anything:
- schemas/monitoring/uss_qualifier/reports/graphs/Node.json
- schemas/monitoring/uss_qualifier/reports/templates/InjectedConfiguration.json
Just the output path automatic deletion to consider IMO. Other than that, LGTM.
| import_submodules(action_generators) | ||
|
|
||
| if os.path.exists(output_path): | ||
| shutil.rmtree(output_path) |
There was a problem hiding this comment.
Slightly dangerous? e.g. if by mistake somebody puts a / or a . as the output path. Or also if that deletes a report we actually wanted to keep. I'd go the safe way by either putting the burden of deleting an existing report to the user (possibly scripted), or by actually creating a new report with some suffix.
There was a problem hiding this comment.
Fair enough, and it's not necessary; removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental new artifact for uss_qualifier reports that displays (per-participant) which requirements were actually tested in the test run (and their outcomes) versus which requirements could potentially have been tested.
Additionally, schema autogeneration now imports the two specific classes we really want schema for rather than importing "everything" (since "everything" changes based on things that shouldn't be relevant).