Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] Add NET0450 to existing checks #205

Merged

Conversation

Shastick
Copy link
Contributor

As discussed with @barroco NET0450 is probably already checked for implicitly, and we need to properly mention that.

@Shastick Shastick force-pushed the net-0450-recency-observations branch from b903284 to 3c5de1f Compare September 14, 2023 15:08
@barroco
Copy link
Contributor

barroco commented Sep 14, 2023

@BenjaminPelletier the intention is to classify the checks between NET0450 and NET0470 with the following approach:

  • NET0450: Check that the observed value is acceptable compared to the value injected.
  • NET0470: Check that the value respects the Common Data Dictionary definition (Table 1).
    Does it sounds reasonable to you?

@Shastick
Copy link
Contributor Author

Shastick commented Sep 14, 2023

@barroco we had a chat with @BenjaminPelletier, his conclusion:

The text of NET0470 is:
A Net-RID Display Provider shall (NET0470) provide
access to required and optional fields defined in Table 1 to
Remote ID Display Applications.
Table 1 lists Geodetic Altitude as required, so if altitude isn't present (or doesn't match what we know it should be), yes, it seems like this requirement would be violated.

I'll update the checks to reflect that

@Shastick Shastick force-pushed the net-0450-recency-observations branch from 3c5de1f to de7b288 Compare September 14, 2023 16:11
@Shastick Shastick force-pushed the net-0450-recency-observations branch from de7b288 to 3953077 Compare September 14, 2023 17:45
@BenjaminPelletier BenjaminPelletier changed the title [uss_qualifier] add NET0450 to existing checks [uss_qualifier] Add NET0450 to existing checks Sep 14, 2023
@BenjaminPelletier BenjaminPelletier merged commit 374a67f into interuss:main Sep 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants