Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] fix missing arguments in record_failed for an aggregate check #196

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[uss_qualifier] fix missing arguments in record_failed for an aggregate check #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions monitoring/uss_qualifier/scenarios/astm/netrid/common/aggregate_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,17 @@ def _sp_flights_area_times_step(self):
) as check:
if p95 > self._rid_version.sp_data_resp_percentile95_s:
check.record_failed(
f"95th percentile of /flights?view requests is {p95} s, "
f"expected less than {self._rid_version.sp_data_resp_percentile95_s} s"
summary=f"95th percentile of /flights?view requests is {p95} s",
severity=Severity.Medium,
participants=[participant],
details=f"expected less than {self._rid_version.sp_data_resp_percentile95_s} s, was {p95}",
)
if p99 > self._rid_version.sp_data_resp_percentile99_s:
check.record_failed(
f"99th percentile of /flights?view requests is {p99} s, "
f"expected less than {self._rid_version.sp_data_resp_percentile99_s} s"
summary=f"99th percentile of /flights?view requests is {p99} s",
severity=Severity.Medium,
participants=[participant],
details=f"expected less than {self._rid_version.sp_data_resp_percentile99_s} s, was {p99}",
)

self.record_note(
Expand Down