-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] Validate that some queries to service_providers are properly authenticated for NET0210 #187
[uss_qualifier] Validate that some queries to service_providers are properly authenticated for NET0210 #187
Conversation
a591c99
to
39b0727
Compare
00fc3ba
to
a325673
Compare
"GET", | ||
fq.query.request.url, | ||
) | ||
server_id = fq.query.get("server_id", "unknown") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that server_id
should be set here once #188 is merged
a325673
to
23c64e6
Compare
monitoring/uss_qualifier/scenarios/astm/netrid/common/misbehavior.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/common/misbehavior.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/common/misbehavior.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/v19/misbehavior.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md
Outdated
Show resolved
Hide resolved
7e792c5
to
3b659d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great -- just the propagated pre-existing issue regarding RIDVersion and I expect this PR to be ready to merge
70c8e5c
to
490163e
Compare
490163e
to
f065c41
Compare
Unsure if this is flaky or due to interfering tests, but I ran into multiple of these failures on the CI:
Will have a look tomorrow. |
flights_data: FlightDataResource, | ||
service_providers: NetRIDServiceProviders, | ||
evaluation_configuration: EvaluationConfigurationResource, | ||
dss_pool: DSSInstancesResource = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since dss_pool requires at least one instance below, this argument shouldn't default to None. But we can clean that up later.
Add check for NET0210, which is about checking that service providers correctly authenticate requests.
This is done via a new
misbehavior
scenario that will inject flight data and query the SP's endpoint for that data without providing credentials.It behaves very similarly to the
nominal_behavior
scenario, with these two tweaks: