Skip to content

Commit

Permalink
[prober] Check for null list of references in create subscription res…
Browse files Browse the repository at this point in the history
…ponses (#108)

* [prober] Check for null list of references in subscription. Ref. #953 in dss repository

* Cover notify_for_operational_intents to false

* Update monitoring/prober/scd/test_subscription_simple.py

Co-authored-by: Mickaël Misbach <[email protected]>

* Update monitoring/prober/scd/test_subscription_simple.py

Co-authored-by: Mickaël Misbach <[email protected]>

* Update dss image to v0.8.0-rc2

---------

Co-authored-by: Mickaël Misbach <[email protected]>
  • Loading branch information
barroco and mickmis authored Jun 16, 2023
1 parent c78eecc commit 982ae5a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions build/dev/docker-compose_dss.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
restart: always

local-dss-rid-bootstrapper:
image: interuss/dss:v0.7.0
image: interuss/dss:v0.8.0-rc2
volumes:
- local-dss-data:/var/local-dss-data
- $PWD/startup:/startup:ro
Expand All @@ -26,7 +26,7 @@ services:
- local-dss-crdb

local-dss-scd-bootstrapper:
image: interuss/dss:v0.7.0
image: interuss/dss:v0.8.0-rc2
volumes:
- local-dss-data:/var/local-dss-data
- $PWD/startup:/startup:ro
Expand All @@ -35,7 +35,7 @@ services:
- local-dss-crdb

local-dss-core-service:
image: interuss/dss:v0.7.0
image: interuss/dss:v0.8.0-rc2
volumes:
- $PWD/../test-certs:/var/test-certs:ro
- local-dss-data:/var/local-dss-data
Expand Down
5 changes: 5 additions & 0 deletions monitoring/prober/scd/test_subscription_simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ def test_create_sub(ids, scd_api, scd_session):
data["subscription"]["time_end"]["value"], req["extents"]["time_end"]["value"]
)
_check_sub1(data, ids(SUB_TYPE), scd_api)
assert "constraint_references" not in data
assert isinstance(data["operational_intent_references"], list)


@for_api_versions(scd.API_0_3_17)
Expand Down Expand Up @@ -156,6 +158,7 @@ def test_mutate_sub(ids, scd_api, scd_session):

req = _make_sub1_req(scd_api)
req["notify_for_constraints"] = True
req["notify_for_operational_intents"] = False

if scd_api == scd.API_0_3_17:
resp = scd_session.put(
Expand All @@ -174,6 +177,8 @@ def test_mutate_sub(ids, scd_api, scd_session):
assert_datetimes_are_equal(
data["subscription"]["time_end"]["value"], req["extents"]["time_end"]["value"]
)
assert isinstance(data["constraint_references"], list)
assert "operational_intent_references" not in data


@for_api_versions(scd.API_0_3_17)
Expand Down

0 comments on commit 982ae5a

Please sign in to comment.