Skip to content

Commit

Permalink
[uss_qualifier] fix missing arguments in record_failed for an aggrega…
Browse files Browse the repository at this point in the history
…te check (#196)

Fix a leftover from the new aggregate checks.
  • Loading branch information
Shastick authored Sep 12, 2023
1 parent 0800a9b commit 8b9bc9d
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,17 @@ def _sp_flights_area_times_step(self):
) as check:
if p95 > self._rid_version.sp_data_resp_percentile95_s:
check.record_failed(
f"95th percentile of /flights?view requests is {p95} s, "
f"expected less than {self._rid_version.sp_data_resp_percentile95_s} s"
summary=f"95th percentile of /flights?view requests is {p95} s",
severity=Severity.Medium,
participants=[participant],
details=f"expected less than {self._rid_version.sp_data_resp_percentile95_s} s, was {p95}",
)
if p99 > self._rid_version.sp_data_resp_percentile99_s:
check.record_failed(
f"99th percentile of /flights?view requests is {p99} s, "
f"expected less than {self._rid_version.sp_data_resp_percentile99_s} s"
summary=f"99th percentile of /flights?view requests is {p99} s",
severity=Severity.Medium,
participants=[participant],
details=f"expected less than {self._rid_version.sp_data_resp_percentile99_s} s, was {p99}",
)

self.record_note(
Expand Down

0 comments on commit 8b9bc9d

Please sign in to comment.