Fix jsonschema treatment of bool fields (#10)

interuss · Aug 11, 2023 · 4d0cba0 · 4d0cba0
1 parent e83bd9a
commit 4d0cba0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/implicitdict/jsonschema.py b/src/implicitdict/jsonschema.py
@@ -162,6 +162,9 @@ def _schema_for(value_type: Type, schema_vars_resolver: SchemaVarsResolver, sche
         make_json_schema(value_type, schema_vars_resolver, schema_repository)
         return {"$ref": schema_vars.path_to(value_type, context)}, False
 
+    if value_type == bool or issubclass(value_type, bool):
+        return {"type": "boolean"}, False
+
     if value_type == float or issubclass(value_type, float):
         return {"type": "number"}, False
 

diff --git a/tests/test_jsonschema.py b/tests/test_jsonschema.py
@@ -1,5 +1,4 @@
 import json
-import os.path
 from typing import Type
 
 import implicitdict.jsonschema

diff --git a/tests/test_types.py b/tests/test_types.py
@@ -148,15 +148,16 @@ class SpecialTypesData(ImplicitDict):
     datetime: StringBasedDateTime
     timedelta: StringBasedTimeDelta
     yesno: YesNo
+    boolean: bool
 
     @staticmethod
     def example_value():
-        return ImplicitDict.parse({"datetime": datetime.utcnow().isoformat(), "timedelta": "12h", "yesno": "Yes"}, SpecialTypesData)
+        return ImplicitDict.parse({"datetime": datetime.utcnow().isoformat(), "timedelta": "12h", "yesno": "Yes", "boolean": "true"}, SpecialTypesData)
 
 
 class NestedDefinitionsData(ImplicitDict):
     special_types: SpecialTypesData
 
     @staticmethod
     def example_value():
-        return ImplicitDict.parse({"special_types": {"datetime": datetime.utcnow().isoformat(), "timedelta": "12h", "yesno": "Yes"}}, NestedDefinitionsData)
+        return ImplicitDict.parse({"special_types": {"datetime": datetime.utcnow().isoformat(), "timedelta": "12h", "yesno": "Yes", "boolean": "true"}}, NestedDefinitionsData)