-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[terraform] #874: terraform module for GCP #886
Conversation
crdb_node_count default value is not accessible from terraform-google-dss. In the meantime, please set the value in your dss_configuration: Edit: The initial intention was to require the node count on each configuration. Values have been added to examples. |
…le joining cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I successfully followed the instructions in deploy/infrastructure/terraform-google-dss/README.md to deploy a single DSS instance using manual DNS configuration. I successfully probed that instance, and successfully destroyed it according to these instructions.
Comments below mostly related to user experience rather than behavior of the system introduced by this PR.
deploy/infrastructure/modules/terraform-google-dss/terraform.example.tfvars
Outdated
Show resolved
Hide resolved
deploy/infrastructure/modules/terraform-google-dss/terraform.example.tfvars
Outdated
Show resolved
Hide resolved
deploy/infrastructure/modules/terraform-google-dss/terraform.example.tfvars
Outdated
Show resolved
Hide resolved
deploy/infrastructure/modules/terraform-google-dss/terraform.example.tfvars
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Pelletier <[email protected]>
Co-authored-by: Benjamin Pelletier <[email protected]>
Co-authored-by: Benjamin Pelletier <[email protected]>
Co-authored-by: Benjamin Pelletier <[email protected]>
…xample.tfvars Co-authored-by: Benjamin Pelletier <[email protected]>
- Update build/deploy/db_schemas/README.md - Change kubernetes_storage_class.tf to google_kubernetes_storage_class.tf - Add "latest" value to specify default db schema version - Move variables descriptions to TFVARS.md instead of the example file - Improve google_zone documentation and add list of options - Fix us-demo.pem path - Include dummy auth option in the authentication variable documentation
f72e55b
to
4470768
Compare
4a4b66b was successfully deployed and the prober generated a successful outcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one new comment and one smaller old comment. But I think it's ready to merge at your discretion.
This PR introduces terraform as a mean to provision the infrastructure required to deploy a DSS as described in #874.
It currently focuses on Google Cloud Engine.
This PR is composed of four key elements:
build/README.md
.The terraform-google-dss is the one exposed to users and requires variables to be passed to it to run. Variables can be provided by various means as described here: https://developer.hashicorp.com/terraform/language/values/variables#assigning-values-to-root-module-variables
For the purpose of providing guidance to users, the documentation uses terraform.tfvars as a mean to provide the variables to the root module.
To test, please follow the steps described in
deploy/infrastructure/modules/terraform-google-dss/README.md
.Please note that modules follow the terraform Standard Module Structure and best practice module composition.
Documentation will be consolidated as we add other cloud providers.
If the PR is too large, I am happy to split it up but it will not be possible to test it.