[scd] factor out parameter validation against previous OIR #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
approved these changes
Aug 30, 2024
mickmis
approved these changes
Aug 30, 2024
| // On success, the version of the OIR is returned: | ||
| // - upon initial creation (if no previous OIR exists), it is 0 | ||
| // - otherwise, it is the version of the previous OIR | ||
| func validateUpsertRequestAgainstPreviousOIRAndReturnVersion( |
There was a problem hiding this comment.
nit: do not return version from this function and just perform validation.
Determining version can then just be:
version := 0
if old != nil {
version = int32(old.Version)
}
Shastick
force-pushed
the
oir-upsert-refactor-1-further-validation
branch
from
7c1f055 to
329993c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the checks that compare the requesting manager to the one of the (possibly) existing OIR to a submethod.
Note the usage of
stacktrace.GetCode(err)andstacktrace.PropagateWithCode(): I'm not sure we have a more elegant solution such as we had in #1089 if we want to avoid this.