[dss][scd] DSS0210,A2-7-2,4d: Consider expired subscriptions as deleted #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
force-pushed
the
DSS0210-A2-7-2-4d-deleted-subscription
branch
6 times, most recently
from
e609824 to
04c2747
Compare
barroco
force-pushed
the
DSS0210-A2-7-2-4d-deleted-subscription
branch
from
04c2747 to
9f7ddae
Compare
…QuerySubscriptions
barroco
force-pushed
the
DSS0210-A2-7-2-4d-deleted-subscription
branch
from
9f7ddae to
0ac22c2
Compare
mickmis
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
FYI I tested the changes locally, all tests pass fine with additional tests from interuss/monitoring#605.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSS0210,A2-7-2,4d requires that expired subscriptions should be automatically deleted. This PR adapts the querySubscription according to tsc investigation (option 2) to filter out expired records.
Note that following the model of RID, a future PR will need to add a garbage collection job. (Option 1)