[helm] Remove default cockroach image value to force user to set it m…

…anually (#1076)
interuss · Aug 29, 2024 · 7db5d3a · 7db5d3a
1 parent 06a9756
commit 7db5d3a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/deploy/services/helm-charts/dss/values.example.yaml b/deploy/services/helm-charts/dss/values.example.yaml
@@ -12,6 +12,8 @@ dss:
 
 cockroachdb:
   # See https://github.com/cockroachdb/helm-charts/blob/master/cockroachdb/values.yaml
+  image:
+    tag: v21.2.7
   fullnameOverride: dss-cockroachdb
   conf:
     join: []

diff --git a/deploy/services/helm-charts/dss/values.schema.json b/deploy/services/helm-charts/dss/values.schema.json
@@ -12,9 +12,13 @@
               "type": "string"
             },
             "tag": {
-              "type": "string"
+              "type": "string",
+              "description": "Version tag of the CockroachDB image. Until DSS v0.16, the recommended CockroachDB version is `v21.2.7`. From DSS v0.17, the recommended CockroachDB version is `v24.1.3`."
             }
-          }
+          },
+          "required": [
+            "tag"
+          ]
         },
         "fullnameOverride": {
           "description": "Name of the internal statefulset",

diff --git a/deploy/services/helm-charts/dss/values.yaml b/deploy/services/helm-charts/dss/values.yaml
@@ -3,7 +3,6 @@ cockroachdb:
   # See https://github.com/cockroachdb/helm-charts/blob/master/cockroachdb/values.yaml
   image:
     repository: cockroachdb/cockroach
-    tag: v21.2.7
   tls:
     certs:
       provided: true