Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $ZF MAX STRINGLENGTH issue #649

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix $ZF MAX STRINGLENGTH issue #649

wants to merge 10 commits into from

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #617

@isc-etamarch isc-etamarch linked an issue Nov 20, 2024 that may be closed by this pull request
<MAX $ZF STRING> trying to commit a very large number of files simultaneously #617
Open
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 95 lines in your changes missing coverage. Please review.

Project coverage is 40.98%. Comparing base (c87d2e7) to head (fe2ab28).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 0.00% 49 Missing ⚠️
cls/SourceControl/Git/WebUIDriver.cls 0.00% 46 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   41.85%   40.98%   -0.87%     
==========================================
  Files          23       23              
  Lines        3027     3091      +64     
==========================================
  Hits         1267     1267              
- Misses       1760     1824      +64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isc-tleavitt
isc-tleavitt requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points of feedback here.

cls/SourceControl/Git/WebUIDriver.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/WebUIDriver.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/WebUIDriver.cls Outdated Show resolved Hide resolved
git-webui/src/share/git-webui/webui/js/git-webui.js Outdated Show resolved Hide resolved
git-webui/src/share/git-webui/webui/js/git-webui.js Outdated Show resolved Hide resolved
git-webui/src/share/git-webui/webui/js/git-webui.js Outdated Show resolved Hide resolved
isc-tleavitt
isc-tleavitt requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments here, sorry for the endless loop of this.

cls/SourceControl/Git/Utils.cls Outdated Show resolved Hide resolved
git-webui/src/share/git-webui/webui/js/git-webui.js Outdated Show resolved Hide resolved
cls/SourceControl/Git/WebUIDriver.cls Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-pbarton isc-pbarton Awaiting requested review from isc-pbarton

@isc-tleavitt isc-tleavitt Awaiting requested review from isc-tleavitt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<MAX $ZF STRING> trying to commit a very large number of files simultaneously
3 participants
@isc-etamarch @codecov-commenter @isc-tleavitt