Update HCC docs #635
Merged
Update HCC docs #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From working session with Daniel Franco today
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
=======================================
Coverage 25.78% 25.78%
=======================================
Files 21 21
Lines 2808 2808
=======================================
Hits 724 724
Misses 2084 2084 ☔ View full report in Codecov by Sentry. |
isc-tleavitt
requested changes
Nov 12, 2024
docs/hcc.md
Outdated
| # Change Control with Embedded Git for Health Connect Cloud | ||
|
|
||
| ## General | ||
| The recommended workflow for Health Connect Cloud is to: create an interface branch, make changes, sync them to GitLab, create a merge request, review and approve the merge request, and then pull the changes into a protected namespace. |
There was a problem hiding this comment.
Nit: "pull the changes" sounds like an action but is automatic with CI/CD.
docs/hcc.md
Outdated
| - Grant appropriate access and privileges to the GitLab repository | ||
| - Onboard customers on source control tools for Health Connect Cloud | ||
| - Maintain change control documentation and videos | ||
| - [Official Change Control Documentation](https://docs.intersystems.com) |
There was a problem hiding this comment.
Can we somehow comment this out for now? (Until we have more official documentation to point to more specifically?)
|
I've made those two changes and put it back for your review |
isc-tleavitt
approved these changes
Nov 13, 2024
|
Thank you @isc-pbarton! We'll probably get some more feedback from DP PM but merging as this is a great step forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #629
Updates to Health Connect Cloud documentation.