Added import-all to basic mode #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isc-pbarton do you think there's any benefit in having this with/without the Force flag? |
|
On second thought I like having just the Import All option and leaving out Import All (Force) because Force is only useful in more advanced debugging scenarios. But I don't have an extremely strong opinion about it. |
|
I thought about this a bunch and discussed with @isc-pbarton and ultimately this is the right thing. We talked about renaming the menu items but the current names make more intuitive sense than anything else we could come up with. There are definitely reasonable use cases for both, even in basic mode. So we'll keep this as-is. |
isc-tleavitt
requested changes
Sep 30, 2024
isc-tleavitt
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498