Add alerts when git is too old #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-tleavitt
requested changes
Sep 24, 2024
There was a problem hiding this comment.
I pulled the rug out from under this - sorry!
Please update version to 2.5.1 in module.xml and put the changelog in the "fixed" section for that new, unreleased version (ultimately I'd call this more of a bugfix as it corrects bad behavior of the extension in cases where it just wouldn't work)
Also, you need to run:
zpm "git-source-control activate"
To get the WebUI change rebuilt and moved to the right place (under the "release" folder which we also commit).
isc-tleavitt
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
@isc-etamarch it's good to put fixed issue numbers in CHANGELOG.md when relevant. I've added that for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #488