Safeguard discard #459
Merged
Safeguard discard #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-tleavitt
requested changes
Aug 16, 2024
What do you mean by menu-based discard? Where would you access that in the UI? |
Replaced "$$$THROWONERROR" with "$$$ThrowOnError"
Fix file restore for files whose directories have been deleted. Refresh uncommited queue after file discard
Fixed the UI so that the "Restore" button in the discarded files is always visible Run a refresh of the uncommitted queue after the discard
isc-tleavitt
requested changes
Sep 27, 2024
isc-tleavitt
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
I think this looks fine from a code standpoint but want to kick the tires on it before merging. @isc-pbarton could you review too?
isc-pbarton
requested changes
Oct 1, 2024
Replaced HTML characters with escaped versions, made sure discarded files are compiled after import
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 25.90% 25.06% -0.84%
==========================================
Files 17 18 +1
Lines 2459 2541 +82
==========================================
Hits 637 637
- Misses 1822 1904 +82 ☔ View full report in Codecov by Sentry. |
isc-pbarton
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #455