Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show other developer's username in Web UI's workspace #319

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

isc-vgao
Copy link
Contributor

This fixes #304

Testing Steps:

  1. In git-source-control repo, checkout otherDevUsername
git checkout otherDevUsername
  1. Load git-source-control into the current namespace
zpm "load <path to local git-source-control repo>"
  1. In Management Portal, navigate to SourceControl_Git.Change table's Execute Query tab (System Explorer > SQL > Tables > SourceControl_Git.Change).
  2. Execute the following Insert query:
INSERT INTO SourceControl_Git.Change (Action, ChangedBy, Committed, CommittedTime, CommittedTimeDisplay, InternalName, ItemFile, Name) VALUES ('edit','abcd', '0', '1840-12-31 00:00:01', 'uncommitted', 'SourceControl.Git.TestDelete.CLS', 'C:\Users\abcd\git-source-control\cls\SourceControl\Git\TestDelete.cls','SourceControl.Git.TestDelete.CLS');
  1. In Management Portal Favorites section, open git-source-control UI and click Workspace on the side navigation menu.
  2. Hover over "cls\SourceControl\Git\TestDelete.cls" in Working Copy section and verify that a popup containing username "abcd" is displayed.
  3. In Management Portal, navigate to SourceControl_Git.Change table's Execute Query tab (System Explorer > SQL > Tables > SourceControl_Git.Change).
  4. Execute the following Delete query:
DELETE from SourceControl_Git.Change where ChangedBy='abcd' and ItemFile='C:\Users\abcd\git-source-control\cls\SourceControl\Git\TestDelete.cls'
  1. Refresh git-source-control UI, navigate to Workspace tab and verify that "cls\SourceControl\Git\TestDelete.cls" is no longer displayed in Working Copy section.

@isc-vgao isc-vgao requested a review from isc-tleavitt January 23, 2024 03:05
@isc-vgao isc-vgao self-assigned this Jan 23, 2024
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on server-side best practices around SQL, exceptions

cls/SourceControl/Git/Change.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Change.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Change.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Change.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Change.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Change.cls Show resolved Hide resolved
@isc-vgao isc-vgao requested a review from isc-tleavitt January 23, 2024 14:29
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tacked on one more fix - looks good now.

@isc-tleavitt isc-tleavitt merged commit fefdb03 into main Jan 23, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the otherDevUsername branch January 23, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git WebUI - show username of other developer with changes to file
2 participants