Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status menu item is now available #285

Merged
merged 2 commits into from
Sep 19, 2023
Merged

status menu item is now available #285

merged 2 commits into from
Sep 19, 2023

Conversation

isc-rsaptars
Copy link
Contributor

Per my conversation with @isc-tleavitt I should have made changes to SourceControl.Git.Extension.UserAction() to route control flow to the appropriate branch in SourceControl.Git.Utils.UserAction(). The menu is accessible without the change. Let me know if there is anything I have missed.

@isc-rsaptars
Copy link
Contributor Author

I closed this PR because I forgot to update the changelog. Will open a new one shortly.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-rsaptars I had a few comments here too. If you want to make changes to a PR after opening it, feel free to just push new commits to it. (You can even reopen this one.)

Was also going to comment about CHANGELOG.md - good call that you need to add that too.

cls/SourceControl/Git/Extension.cls Outdated Show resolved Hide resolved
cls/SourceControl/Git/Extension.cls Show resolved Hide resolved
@isc-tleavitt isc-tleavitt reopened this Sep 18, 2023
@isc-tleavitt isc-tleavitt merged commit c7da0f1 into main Sep 19, 2023
2 checks passed
@isc-tleavitt isc-tleavitt deleted the add-status-menu branch September 19, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants