ZPM load in dev mode will build the javascript application #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-tleavitt
requested changes
Sep 14, 2023
cls/SourceControl/Git/Build.cls
Outdated
| write !, "In developer mode, building web UI:" | ||
| set webUIDirectory = ##class(%File).SubDirectoryName(rootDirectory, "git-webui") | ||
| write !, "npm install" | ||
| write !, $zf(-100, "/SHELL", "cd", webUIDirectory, "&&", "npm", "install") |
There was a problem hiding this comment.
This should be npm install --prefix webUIDirectory rather than using cd. (Same below, npm run --prefix)
There was a problem hiding this comment.
At least for me, npm install does not respect --prefix. But npm ci --prefix does work.
isc-tleavitt
approved these changes
Sep 18, 2023
|
As this is internal I don't think we need anything in changelog.md but feel free to add if you disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37