fixed issue #250 -- Set up default mappings with SourceControl.Git.Se…

…ttings
intersystems · Sep 13, 2023 · f0855e8 · f0855e8
1 parent b9ac45d
commit f0855e8
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/cls/SourceControl/Git/API.cls b/cls/SourceControl/Git/API.cls
@@ -12,10 +12,7 @@ ClassMethod Configure()
         write !,"Configured SourceControl.Git.Extension as source control class for namespace ",$namespace
         set mappingsNode = ##class(SourceControl.Git.Utils).MappingsNode()
         if '$data(@mappingsNode) {
-            set @mappingsNode@("CLS","*")="cls/"
-            set @mappingsNode@("CLS","UnitTest")="test/"
-            set @mappingsNode@("INC","*")="inc/"
-            set @mappingsNode@("MAC","*")="rtn/"
+            do ##class(SourceControl.Git.Utils).SetDefaultMappings(mappingsNode)
             write !,"Configured default mappings for classes, routines, and include files. You can customize these in the global:",!?5,mappingsNode
         }
         set gitExists = ##class(SourceControl.Git.Utils).GitBinExists(.version)

diff --git a/cls/SourceControl/Git/Settings.cls b/cls/SourceControl/Git/Settings.cls
@@ -30,7 +30,11 @@ Property Mappings [ MultiDimensional ];
 
 Method %OnNew() As %Status
 {
-    merge ..Mappings = @##class(SourceControl.Git.Utils).MappingsNode()
+    set mappingsNode = ##class(SourceControl.Git.Utils).MappingsNode()
+    if '$data(@mappingsNode) {
+        do ##class(SourceControl.Git.Utils).SetDefaultMappings(mappingsNode)
+    }
+    merge ..Mappings = @mappingsNode
     set gitBinPath = ##class(SourceControl.Git.Utils).GitBinPath(.isDefault)
     if ('isDefault) {
         set ..gitBinPath = gitBinPath
@@ -168,3 +172,4 @@ Method OnAfterConfigure() As %Boolean
 }
 
 }
+
diff --git a/cls/SourceControl/Git/Utils.cls b/cls/SourceControl/Git/Utils.cls
@@ -233,7 +233,8 @@ ClassMethod UserAction(InternalName As %String, MenuName As %String, ByRef Targe
         set ec = ..AddToSourceControl(InternalName)
     } elseif (menuItemName = "RemoveFromSC") {
         set ec = ..RemoveFromSourceControl(InternalName)
-    } elseif (menuItemName = "Commit") {
+    } // is there any reason this code block is repeated?
+    elseif (menuItemName = "Commit") {
         set Target = "Please enter a commit message"
         set Action = 7
         quit $$$OK
@@ -1986,5 +1987,13 @@ ClassMethod BuildCEInstallationPackage(ByRef destination As %String) As %Status
     quit sc
 }
 
+ClassMethod SetDefaultMappings(mappingsNode As %String)
+{
+    set @mappingsNode@("CLS","*")="cls/"
+    set @mappingsNode@("CLS","UnitTest")="test/"
+    set @mappingsNode@("INC","*")="inc/"
+    set @mappingsNode@("MAC","*")="rtn/"
+}
+
 }