Skip to content

Commit

Permalink
Merge pull request #628 from intersystems/commit-encoding
Browse files Browse the repository at this point in the history
Fix Unicode encoding of Git commands from web UI
  • Loading branch information
isc-tleavitt authored Nov 8, 2024
2 parents 659a268 + a97f823 commit 2db11a5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [2.7.1] - Unreleased

### Fixed
- Fixed improper encoding of unicode characters in commit messages (#627)
- Creating a new branch now reports the error if uncommitted changes conflict (#624)

## [2.7.0] - 2024-11-04
Expand Down
7 changes: 6 additions & 1 deletion cls/SourceControl/Git/WebUIDriver.cls
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,12 @@ ClassMethod HandleRequest(pagePath As %String, InternalName As %String = "", Out
}
set handled = 1
} elseif (pathStart = "git-command") {
set requestBody = ##class(%Library.DynamicObject).%FromJSON(%request.Content)
set stringBody = ""
while '%request.Content.AtEnd {
set stringBody = stringBody _ %request.Content.Read()
}
set stringBody = $zconvert(stringBody,"I","UTF8")
set requestBody = ##class(%Library.DynamicObject).%FromJSON(stringBody)
set command = requestBody.command

set gitCmd = command.%Get(0)
Expand Down

0 comments on commit 2db11a5

Please sign in to comment.