Provide Project and User parameters to Studio add-ins #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/commands/serverActions.ts
Outdated
| ); | ||
| let params = `Namespace=${nsEncoded}`; | ||
| params += `&User=${encodeURIComponent(username)}`; | ||
| params += `&Project=${encodeURIComponent(project)}`; |
There was a problem hiding this comment.
If we don't have a project (which will be most cases), should we not pass the parameter instead of passing it with an empty value? I don't know if that matters.
There was a problem hiding this comment.
Good idea. I have pushed a change to do that.
isc-bsaviano
approved these changes
Jul 22, 2024
|
Thanks for the approval. Shall we do a 2.12.6 release soon, since we've now reached beta.15? |
|
Sure, I can create a PR. Should we do a server manager as well? |
|
Yes please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://docs.intersystems.com/ens201817/csp/docbook/DocBook.UI.Page.cls?KEY=GSTD_Templates#GSTD_template_arch a Studio add-in may expect
ProjectandUserin its %request object.