Edit Settings command opens JSON file

[isc-bsaviano]

This PR fixes #227

[gjsjohnmurray]

I have also been looking at this, and in future we should probably do a better job of coordinating who's working on what.

Opening settings as JSON at a particular key can already be done more simply:

	vscode.commands.executeCommand("workbench.action.openSettingsJson", { revealSetting: { key: "intersystems.servers" } });

But because of the way our package.json defines this object the following doesn't go to the specific entry:

	vscode.commands.executeCommand("workbench.action.openSettingsJson", { revealSetting: { key: `intersystems.servers.${server.name}` } });

So I suggest you refine your revealServers technique to find the sub-object that matches server.name (perhaps rename the function revealServer).

It might be safer not to select any characters though, as doing so creates a risk of the user inadvertently deleting or overtyping.

[isc-bsaviano]

Sorry John, I should have assigned myself. I didn't know about revealSetting, I will definitely adopt that. I see your point about the selection potentially being dangerous. I'll remove that as well.

[gjsjohnmurray]

revealSetting should be able to get you close, but I suggest you augment it with a forward scan to find the definition of the actual server the user invoked the command from.

[gjsjohnmurray]

👍