Ref #670 - Change MX result caching to IP-based #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't remember the details but could this result in tests that rely on the hostname (like DANE and the certificate tests) to be shared among different hostnames with the same IPs? |
You are entirely right. Thanks for spotting this! |
|
Ah yes, so this is unfortunately not going to work. The idea behind it was mainly to prevent hitting rate limits. Idea (not for v1.7): maybe (mainly for the batch test) we can prevent MX's that have a different hostname but have the same IP address(es) from being tested too soon after each other. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial, but simple change: our original cache was based on the hostname in the MX result. Now, it's based on the A+AAAA that this hostname resolves to, at the cost of an extra resolve call, but resolving is cheap. This helps when multiple hostnames resolve to the same set of A+AAAA, but not when different MX hostnames resolve to slightly different sets of IPs. The latter would be more complex, and I'd first want to have a plan for #714.