Add cron to cleanup dangling single tests and batch periodic test reports #1579
Conversation
aequitas
force-pushed
the
db_cleanup
branch
4 times, most recently
from
a3fa3d0 to
c744619
Compare
Signed-off-by: Sasha Romijn <[email protected]>
| migrations.AddField( | ||
| model_name="webtestappsecpriv", | ||
| name="timestamp", | ||
| field=models.DateTimeField(auto_now_add=True, default=datetime.datetime(1, 1, 1, 0, 0)), |
There was a problem hiding this comment.
Will auto_now_add also apply to existing rows at the time of migration? Or will it only do that when adding a new object through ORM? Otherwise, we will be expiring currently existing reports early.
There was a problem hiding this comment.
This should set the date to epoch(0) for existing records. I will test it out to make sure.
There was a problem hiding this comment.
Yes but that's bad, right? If the cleanup runs right after deployment, it'll consider every report old, and start cleaning.
There was a problem hiding this comment.
The cleanup does not touch single test reports, only probe/test results. It will delete results that don't have a report associated and are not recent enough to be currently running. The timestamp is added to these 2 models because they don't have it yet while other tests in the report do.
No description provided.