Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated errors message if hostname response to A/AAAA records #2610

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OlegPhenomenon
Copy link
Contributor

What's the issue?

  • The problem is an error message appearing during email validation, even though the validation result is positive. In other words, the email passes the validation and has an attribute success = true, but still, in the errors field, contains error information such as target host(s) not found.

Why does this error occur?

  • The hostname of the email box is checked by the Truemail gem, and indeed, MX record-based email validation may yield an error. However, this does not mean the email is invalid. The email can also resolve to A/AAAA records, which allows the use of this mailbox. The problem is that Truemail logs error information, while additional validation based on A/AAAA records returns a positive result.

How did you solve it?

  • If the A/AAAA validation result turned out to be positive, then I update the error information to the following text: target host(s) not found, but was able to find A/AAAA records for domain.

How to test?

  • Appropriate emails must be available that do not pass MX validation but have A/AAAA records at the same time. Run the rake task bundle exec rake verify_email:check_all -- --check_level=mx --spam_protect=true, and make sure that the ValidationEvent entries associated with the contact have a success==true result, as well as the error record target host(s) not found, but was able to find A/AAAA records for domain

@viezly
Copy link

viezly bot commented Aug 28, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@OlegPhenomenon OlegPhenomenon force-pushed the fd-lifting-with-bounce-emails branch 12 times, most recently from 96075ac to 459db5c Compare August 29, 2023 07:41
@OlegPhenomenon OlegPhenomenon force-pushed the fd-lifting-with-bounce-emails branch 2 times, most recently from 63f679b to c8bbe11 Compare August 29, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants